-
Notifications
You must be signed in to change notification settings - Fork 27
/
Copy pathfile.go
88 lines (72 loc) · 1.83 KB
/
file.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
// Copyright (c) Efficient Go Authors
// Licensed under the Apache License 2.0.
package leak
import (
"io"
"os"
"github.com/efficientgo/core/errcapture"
"github.com/efficientgo/core/logerrcapture"
"github.com/efficientgo/core/merrors"
"github.com/go-kit/log"
"github.com/go-kit/log/level"
)
// Example on common leaks using `os.File`.
// Read more in "Efficient Go"; Example 11-8.
func doWithFile_Wrong(fileName string) error {
f, err := os.Open(fileName)
if err != nil {
return err
}
defer f.Close() // Wrong!
// Use file...
return nil
}
func doWithFile_LogCloseErr(logger log.Logger, fileName string) {
f, err := os.Open(fileName)
if err != nil {
level.Error(logger).Log("err", err)
return
}
defer logerrcapture.Do(logger, f.Close, "close file")
// Use file...
}
func doWithFile_CaptureCloseErr(fileName string) (err error) {
f, err := os.Open(fileName)
if err != nil {
return err
}
defer errcapture.Do(&err, f.Close, "close file")
// Use file...
return nil
}
// Example on common leaks using `os.File` when multiple files are used.
// Read more in "Efficient Go"; Example 11-9.
func openMultiple_Wrong(fileNames ...string) ([]io.ReadCloser, error) {
files := make([]io.ReadCloser, 0, len(fileNames))
for _, fn := range fileNames {
f, err := os.Open(fn)
if err != nil {
return nil, err // Leaked files!
}
files = append(files, f)
}
return files, nil
}
func openMultiple_Correct(fileNames ...string) ([]io.ReadCloser, error) {
files := make([]io.ReadCloser, 0, len(fileNames))
for _, fn := range fileNames {
f, err := os.Open(fn)
if err != nil {
return nil, merrors.New(err, closeAll(files)).Err()
}
files = append(files, f)
}
return files, nil
}
func closeAll(closers []io.ReadCloser) error {
errs := merrors.New()
for _, c := range closers {
errs.Add(c.Close())
}
return errs.Err()
}