Skip to content

Commit

Permalink
Merge pull request #364 from ef4/app-template-explicit
Browse files Browse the repository at this point in the history
test apps should not automatically depend on auto-import
  • Loading branch information
ef4 authored Mar 24, 2021
2 parents c1898c2 + b3de256 commit 1e5b8f1
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/app-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"@ember/optional-features": "^1.0.0",
"babel-eslint": "^10.0.3",
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "1.10.1",
"ember-cli-app-version": "^3.2.0",
"ember-cli-babel": "^7.11.1",
"ember-cli-dependency-checker": "^3.1.0",
Expand Down
1 change: 1 addition & 0 deletions test-scenarios/ember-cli-typescript-2-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ appScenarios
});
project.addDevDependency(aDependency);
project.linkDevDependency('ember-cli-typescript', { baseDir: __dirname, resolveName: 'ember-cli-typescript-2' });
project.linkDevDependency('ember-auto-import', { baseDir: __dirname });
project.linkDevDependency('typescript', { baseDir: __dirname, resolveName: 'typescript-4' });

merge(project.files, {
Expand Down
1 change: 1 addition & 0 deletions test-scenarios/ember-cli-typescript-3-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ appScenarios
});
project.addDevDependency(aPureTSDependency);

project.linkDevDependency('ember-auto-import', { baseDir: __dirname });
project.linkDevDependency('ember-cli-typescript', { baseDir: __dirname, resolveName: 'ember-cli-typescript-3' });
project.linkDevDependency('typescript', { baseDir: __dirname, resolveName: 'typescript-4' });

Expand Down
1 change: 1 addition & 0 deletions test-scenarios/ember-cli-typescript-4-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ appScenarios
},
});
project.addDevDependency(aDependency);
project.linkDevDependency('ember-auto-import', { baseDir: __dirname });
project.linkDevDependency('ember-cli-typescript', { baseDir: __dirname, resolveName: 'ember-cli-typescript-4' });
project.linkDevDependency('typescript', { baseDir: __dirname, resolveName: 'typescript-4' });

Expand Down
1 change: 1 addition & 0 deletions test-scenarios/skip-babel-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ appScenarios
},
});
project.addDevDependency(aModuleDependency);
project.linkDevDependency('ember-auto-import', { baseDir: __dirname });

merge(project.files, {
'ember-cli-build.js': EMBER_CLI_BUILD_JS,
Expand Down

0 comments on commit 1e5b8f1

Please sign in to comment.