-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to zap
non-.class
files
#48
Comments
I kind of like the idea of removing the |
I agree that reusing zap is ideal and removing non-class files from a jar is a real use case. |
I initially played around with updating |
👋 Hi Eugene, Oscar. Thanks Adam for your PR. I've prepared PR #53 that generalizes Since |
Thanks for the contribution @patrick-premont! #53 is merged. |
👋 Hey, we're trying to use
jarjar
via https://github.com/bazeltools/bazel_jar_jar while migrating a build to Bazel from Gradle. The Gradle shadow plugin that we're trying to replace allows for the removal of any file type/extension as part of the jar shading process. It appears that theZapProcessor
only allowszap
ing.class
files.jarjar-abrams/jarjar/src/main/java/com/eed3si9n/jarjar/ZapProcessor.java
Lines 31 to 36 in 9d0eb03
I was thinking of removing this constraint to
zap
, but wanted to see if there were any objections before going too far down that path.Alternatively, are there other suggestions for how to handle this use-case? We're currently seeing
.proto
files & native libraries added to the shaded jar, but would like them excluded.The text was updated successfully, but these errors were encountered: