feat: Added support for Node 16 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 71 71
Lines 1641 1641
Branches 404 404
=======================================
Hits 1623 1623
Misses 18 18 Continue to review full report at Codecov.
|
mraarif
reviewed
Jan 17, 2022
mraarif
reviewed
Jan 18, 2022
aht007
reviewed
Jan 27, 2022
mraarif
reviewed
Jan 28, 2022
Jawayria
force-pushed
the
jawayria/support-node-16
branch
from
9ecab4a to
e99bf26
Compare
Jawayria
commented
Mar 29, 2022
| COPY src/courseOutlineHealthCheckIndex.jsx src/courseOutlineHealthCheckIndex.jsx | ||
| COPY src/data/i18n/locales src/data/i18n/locales | ||
| COPY src/editImageModalIndex.jsx src/editImageModalIndex.jsx | ||
| COPY src/index.jsx src/index.jsx |
There was a problem hiding this comment.
I was getting 'not found' error for these files while building docker image so I explicitly copied all these files to docker.
aht007
approved these changes
Mar 29, 2022
connorhaugh
approved these changes
Mar 29, 2022
Jawayria
force-pushed
the
jawayria/support-node-16
branch
from
d139be9 to
72d74d3
Compare
ghassanmas
added a commit
to ghassanmas/studio-frontend
that referenced
this pull request
Apr 28, 2022
The PR openedx#315 added @babel/core >= 7.*. upgrading/using babel v7 requires, making certian changes, e.g using @babel...etc. This lead to `npm run build` being interrupted/exited.without generating the /dist folder. Luckily, there is a pacakge to automate migration of config using `npx babel-upgrade --write`, followed by `npm install`, and few minor changes, the dist folder came to life again. This shall fixes this openedx/wg-build-test-release#166. and probably making this openedx/edx-platform#30309 unnecessary.
ghassanmas
added a commit
to ghassanmas/studio-frontend
that referenced
this pull request
May 12, 2022
The PR openedx#315 added @babel/core >= 7.*. upgrading/using babel v7 requires, making certian changes, e.g using @babel...etc. This lead to `npm run build` being interrupted/exited.without generating the /dist folder. Luckily, there is a pacakge to automate migration of config using `npx babel-upgrade --write`, followed by `npm install`, and few minor changes, the dist folder came to life again. This shall fixes this openedx/wg-build-test-release#166. and probably making this openedx/edx-platform#30309 unnecessary. Note: This change adds "^7.0.0-bridge.0" as devDep, this is needed because we have pacakges that uses Babel 6, which are jest and babel-jest. once we upgrade to babel-jest and jest >=24.*.* the pacakge shall be removed.
aht007
pushed a commit
that referenced
this pull request
May 13, 2022
The PR #315 added @babel/core >= 7.*. upgrading/using babel v7 requires, making certian changes, e.g using @babel...etc. This lead to `npm run build` being interrupted/exited.without generating the /dist folder. Luckily, there is a pacakge to automate migration of config using `npx babel-upgrade --write`, followed by `npm install`, and few minor changes, the dist folder came to life again. This shall fixes this openedx/wg-build-test-release#166. and probably making this openedx/edx-platform#30309 unnecessary. Note: This change adds "^7.0.0-bridge.0" as devDep, this is needed because we have pacakges that uses Babel 6, which are jest and babel-jest. once we upgrade to babel-jest and jest >=24.*.* the pacakge shall be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for node 14 and node 16. I had to make some additional changes to ensure successful tests execution and tobuild docker image successfully on node 16.
Additional Changes
Syntax Error: Support for the experimental syntax 'jsx' isn't currently enabled in react jsmodule build failed (from ./node_modules/babel-loader/lib/index.js) syntaxerror unexpected tokendescribe: optionsSchema.definitions.output.properties.path.description with webpack 4.8.3Error: 'node-sass' version 6.0.0 is incompatible with ^4.0.0