fix: timer polling url for LTI exams #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 93.78% 93.96% +0.18%
==========================================
Files 71 71
Lines 1030 1028 -2
Branches 281 281
==========================================
Hits 966 966
+ Misses 59 57 -2
Partials 5 5
☔ View full report in Codecov by Sentry. |
alangsto
approved these changes
Aug 23, 2023
|
🎉 This PR is included in version 2.20.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
pedromartello
pushed a commit
to hammerlabs-net/frontend-lib-special-exams
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query string appears to just be some copy/paste from the old proctoring UI. It's not used for anything and causes the pollHandler to send failing requests if the attempt has no polling url. The cropped up after #113 was merged.
Tested manually. At the moment this component has no tests 😞