Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial basic footer #1

Merged
merged 5 commits into from
Sep 30, 2019
Merged

Conversation

abutterworth
Copy link
Contributor

Usage

To install frontend-component-footer-edx into your project

   npm i --save @edx/frontend-component-footer-edx

Component Usage

   import Footer from '@edx/frontend-component-footer-edx';
   import footerMessages from '@edx/frontend-component-footer-edx/src/i18n/index';

   ...

   <Footer
      handleAllTrackEvents={(eventName, properties) => {/* track click event */}}
      onLanguageSelected={(languageCode) => {/* set language */}}
      supportedLanguages={[
         { label: 'English', value: 'en'},
         { label: 'Español', value: 'es' },
      ]}
   />
  • handleAllTrackEvents (required)
  • onLanguageSelected (optional)
  • supportedLanguages (optional)

@abutterworth abutterworth requested a review from a team September 27, 2019 13:41
.travis.yml Outdated Show resolved Hide resolved

const App = () => (
<div>
<IntlProvider locale="en">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, you should be able to use frontend-base in this example app, like the header repos. (I don't feel strongly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure this is just as easy.

package.json Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@221a831). Click here to learn what that means.
The diff coverage is 96%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #1   +/-   ##
======================================
  Coverage          ?   96%           
======================================
  Files             ?     8           
  Lines             ?    50           
  Branches          ?     6           
======================================
  Hits              ?    48           
  Misses            ?     2           
  Partials          ?     0
Impacted Files Coverage Δ
src/i18n/index.js 0% <0%> (ø)
src/components/LanguageSelector.jsx 100% <100%> (ø)
src/components/AppleAppStoreButton.jsx 100% <100%> (ø)
src/components/SocialIconLinks.jsx 100% <100%> (ø)
src/components/GooglePlayStoreButton.jsx 100% <100%> (ø)
src/components/Footer.messages.js 100% <100%> (ø)
src/components/Footer.jsx 100% <100%> (ø)
src/components/LinkList.jsx 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221a831...509a30d. Read the comment docs.

@davidjoy davidjoy merged commit 857be9c into master Sep 30, 2019
@davidjoy davidjoy deleted the abutterworth/basic-implementation branch September 30, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants