Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hotjar suppression to PII #385

Merged

Conversation

zainab-amir
Copy link
Contributor

@zainab-amir zainab-amir commented Sep 21, 2020

Hotjar is a behavior analytics tool that analyses website use, providing feedback through tools such as heatmaps, session recordings, and surveys. Before we enable hotjar we have to suppress all PII and sensitive information so that screen recorder doesn’t capture it. Adding a data-hj-suppress attribute around the sensitive data marks the field as suppressed for hotjar and shows asterisks instead of text.
Screenshot 2020-09-16 at 10 03 02 AM

For Profile MFE, PII identified and suppressed are:

Ticket: VAN-35

@zainab-amir zainab-amir force-pushed the zamir/VAN-35/suppress_pii_for_hotjar_integration branch from 49ee807 to a26a937 Compare September 21, 2020 10:59
Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to suppress the profile image and location as well?

Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@zainab-amir zainab-amir merged commit 2f9f573 into master Sep 22, 2020
@zainab-amir zainab-amir deleted the zamir/VAN-35/suppress_pii_for_hotjar_integration branch September 22, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants