Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace whitelist_externals with allowlist_externals in tox file for all repos #130

Closed
aht007 opened this issue Dec 8, 2022 · 1 comment
Assignees

Comments

@aht007
Copy link
Member

aht007 commented Dec 8, 2022

whitelist_externals has been deprecated in tox for a long time. See: Changelogs.
This came into light when tox was upgraded to version 4.0.0 in upgrade PRs and some PRs failed due to this. For now tox has been pinned to <4.0.0 due to other breaking changes too but we should fix this issue so that whenever we upgrade tox to some version >4.0.0 we don't face this issue again.
A better approach to handle this would be to write a script and run it through bulk repo update job to make all the PRs in one go

@aht007 aht007 added this to Arbi-BOM Dec 8, 2022
@aht007 aht007 converted this from a draft issue Dec 8, 2022
@iamsobanjaved
Copy link
Member

This is now removed in tox==4.0.0 and we have to replace this with allowlist_externals so we are unblocked to upgrade tox to latest version.

Filtered view from Repo Health Dashboard about the usage of whitelist_externals: https://github.com/tox-dev/tox/blob/main/docs/changelog.rst#deprecations-and-removals---400rc4

Removal from tox version 4.0.0: https://github.com/tox-dev/tox/blob/main/docs/changelog.rst#deprecations-and-removals---400rc4

This was referenced Oct 20, 2023
This was referenced Oct 23, 2023
@UsamaSadiq UsamaSadiq moved this from Todo to In Progress in Arbi-BOM Oct 27, 2023
@UsamaSadiq UsamaSadiq moved this from In Progress to Author Team Review in Arbi-BOM Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Author Team Review to Done in Arbi-BOM Nov 15, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arbi-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

4 participants