-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP-Authentification #23
Comments
Do you mean basic authentication? |
yes |
I'm unsure of how we would distribute the credentials in a safe way. Putting it inside the manifest would be unsafe I think. |
i think that's true ... maybe you could type the credentials into a extra file and while creating the manifest the CreateManifest generates a Hash of the password and stores only the hash inside the maniest? |
If it stores only the hash we can't possible re-create the credentials from the hash when it's time to make the http request with the credentials :) |
wouldnt it be enough to transmit only the hash? |
The client needs to send username/password crendentials which can be matched against the hash. You can't just send the hash. If you send the hash, that is basically the password, so that makes no sense. Either way, storing the credentials that give you access to the resource in the manifest would be unsafe. What about this: If the remote update server requires authentication, we prompt the user for it? |
of course this would be a good idea, but i would also think the option to store them inside the manifest, of course this is not secure but on systems that do not really need security but have http-basic-authentication enabled it would be posible to make a user that has only acces to the update files. maybe switching between variants or none would be good |
In that case you can just add basic auth parameters to the url like this:
This can be easily extracted via the |
sounds good, but did not work for me, i already tried this yesterday. our application-server explicitly wants the credentials inside the http-header, not in the url .... |
Of course, but if you're fine with that approach, I'll make sure FXLauncher adds the header :) Should we try this? |
sounds good! :-) |
Great, I just committed support for basic auth credentials in the urlinfo part of the manifest url. Let me know how it turns out! |
currently i do not know why but it does not work. i tried it in my webrowser and this worked only when i did not enter "http://" i tried it in te manifest-file with http:// and without http:// i also tried including the port but it does not update. |
I'm not sure what you mean. Do basic auth only work in your browser when you don't add http://? Can you try to start it via |
I have confirmed that this is working now - you can include credentials in the url like: |
Hi Edvin, I've spent the past 12 hours reading your content and all the different questions, but I'm still struggling to deploy the files to my web server. I'll try to be succinct of the problem. The pom file is at the bottom.
However, despite receiving a BUILD SUCCESS message with the Obervation: From 1.08 to 1.12 in your screencast it shows you uploading the files to You mention using I tried the following different combinations, editing the
Questions:
Deploying with I'm clearly confused about a number of issues, can you please help me out? Thanks so much! pom.xml (pastebin link) |
Hi, The maven example uses I suspect your problem is that you either do not have Another alternative is simply to skip the Do not confuse this with the Down the line I'm going to create a Maven plugin for FXLauncher (like we have for Gradle). In there I could probably support built in transfer using SSH and/or FTP to make this a bit easier. |
Very helpful reply, I should be fine from here on out. Thank you very much |
Please let me know if you get stuck, we'll make sure you get this working :) |
Hi Edvin, I wanted to try my best before responding, but I can proudly say I got it working with my FTP server. I'm very impressed with what you've created. I have a few resulting questions that I'm hoping you can clarify, I didn't know whether to start a new "Issue" or not, since they're not really issues. For reference, here is my pom.xml Steps:
Questions:
I need to rely on FXLauncher in a commercial application, so have to fully understand what I'm doing. Thanks for your time Edvin. Additional Notes: |
Glad to hear that you got it working!
Your pom looks perfect :) |
Hi Edvin, For the past 4 days I've struggled to migrate the pom away from using ftp over to sftp. The I'm using CoreFTP's free mini-server (localhost, port 22) to test how FXLauncher works with sftp, I have freeSSHd running, can access/transfer files through the client GUI and also by using this functional SSCCE but when I run
Right now I'm using Have you any ideas as to how we can use FXLauncher with SFTP (localhost or otherwise) referring to |
You are mixing a couple of concepts here. First of all, Unless the manifest and resources are not protected by basic auth, the app url should not contain user:pass or :22 (port 22 is used for ssh, while your webserver probably runs on the default port 80). In your pom, set For example, lets say your app is hosted at You should then be able to test the file upload manually by doing Based on your pom I would say you are nearly there, just put the scp url in the Hope this helps :) |
Look at line 55 in your pom :) Put the scp/sftp url there. Sftp/scp urls are interchangeable. You can leave the sftpexe:// part out, just start the url with your username :) If this doesn't help I'll try to create a screencast to describe this better :) |
Basic auth is not working for me: i.e.<app.url>http://user:[email protected]/**ignoredpath**</app.url> show exception: FileNotFoundException: http://user:[email protected]/someJar.jar The path is ignored... Any hints? Thanks |
So you want it to access http://user:[email protected]/ignoredpath/someJar.jar and it tries to access http://user:[email protected]/someJar.jar is that correct? |
yes, this is correct |
OK, thanks. I will have a look as soon as I can. Can you create a separat issue? This one is about the addition of basic auth, while your issue seems to be a bug. Better to track it in a separate issue. |
ok, here we go: #32 |
Thank you. I will get to it shortly. |
Hello everyone! My pom.xml <app.url>http://user@hostname:/home/xyz/apache-tomcat-6.0.20/webapps/App</app.url> <app.deploy.target>/home/xyz/apache-tomcat-6.0.20/webapps/App</app.deploy.target> Result when I execute: mvn exec:exec@deploy-app Where should I store the password for the scp??? I tried also in pom.xml Any directions? |
The best way to deal with ssh credentials is by copying your public key ( <app.deploy.target>username@hostname:/home/xyz/apache-tomcat-6.0.20/webapps/App</app.deploy.target> |
FIXED: pom.xml ΤΗΑΝΚΣ!!! |
That sounds about right :) Great! |
But I have another small problem :-( If I manually copy fxlauncher.jar to: /target/app/ then packaging works well... Any ideas why packaging fails? Best, |
Thank you so much for spending time for us newbies!!!
…Sent from my iPhone
On 27 May 2017, at 16:39, Edvin Syse ***@***.***> wrote:
That sounds about right :) Great!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
My pleasure :) |
@edvin this is the current pom.xml |
You can simply change the url and redeploy your app to both the old and new location, then clients will retrieve the files from the new location after they have contacted the old location once. |
it would be good to enable optional http authentification for the update-server
The text was updated successfully, but these errors were encountered: