From b4726ef036daf60fa69e5b1148b61a49e7f45abc Mon Sep 17 00:00:00 2001 From: Edvin Syse Date: Tue, 17 Jul 2018 21:28:44 +0200 Subject: [PATCH] What's New now expects fully qualified URL (https://github.com/edvin/fxlauncher/issues/125) --- CHANGELOG.md | 1 + README.md | 2 +- src/main/java/fxlauncher/Launcher.java | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 94d4366..0291ab4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file. ## [1.0.20-SNAPSHOT] - Include artifact classifiers when copying dependencies +- What's New now expects fully qualified URL (https://github.com/edvin/fxlauncher/issues/125) ## [1.0.19] diff --git a/README.md b/README.md index 35630e7..a24c1ab 100644 --- a/README.md +++ b/README.md @@ -156,7 +156,7 @@ the value of `--stop-on-update-errors` will be used. ## Show what's new dialog. You can have FXLauncher show a whats new dialog. This dialog will -only be shown when FXLauncher has to download new files from the server. The html content will be shown in a `WebView`. Specify `--whats-new=https://whatsnewurl/here` +only be shown when FXLauncher has to download new files from the server. The html will be shown in a `WebView`. Specify `--whats-new=https://whatsnewurl/here` ### Applications with no default UI diff --git a/src/main/java/fxlauncher/Launcher.java b/src/main/java/fxlauncher/Launcher.java index 5e60d60..1437d21 100644 --- a/src/main/java/fxlauncher/Launcher.java +++ b/src/main/java/fxlauncher/Launcher.java @@ -192,9 +192,9 @@ private void launchAppFromManifest(boolean showWhatsnew) throws Exception { }); } - private void showWhatsNewDialog(String whatsNewPage) { + private void showWhatsNewDialog(String whatsNewURL) { WebView view = new WebView(); - view.getEngine().load(Launcher.class.getResource(whatsNewPage).toExternalForm()); + view.getEngine().load(whatsNewURL); Alert alert = new Alert(Alert.AlertType.INFORMATION); alert.setTitle("What's new"); alert.setHeaderText("New in this update");