Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation & api dependencies don't copy #21

Open
nhajratw opened this issue Jul 13, 2018 · 5 comments
Open

implementation & api dependencies don't copy #21

nhajratw opened this issue Jul 13, 2018 · 5 comments

Comments

@nhajratw
Copy link

Newer gradle versions recommend using the implementation or api keywords instead of compile and runtime. Unfortunately, the plugin doesn't seem to pick up dependencies declared in that way.

https://docs.gradle.org/current/userguide/dependency_management_for_java_projects.html

@nintha
Copy link

nintha commented Aug 14, 2018

Yep, generateApplicationManifest creates full files , but generateNativeInstaller only copys fxlauncher.jar to bundle.

Now, I use javapackager like it:

javapackager -deploy -native -outdir build -srcdir build/fxlauncher -appclass fxlauncher.Launcher -outfile myapp -name myapp -title myapp -vendor nintha

the batch can instead of generateNativeInstaller after run generateApplicationManifest.

Good luck

@TurekBot
Copy link
Contributor

The CopyAppDependenciesTask is really short and sweet, so this shouldn't be too hard, right?

I'm a total noob when it comes to groovy, but it seems this might be fixed on this line:

project.configurations.runtime.resolvedConfiguration.resolvedArtifacts.each { artifact ->

Here's something helpful!

A dependency graph

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_configurations_graph

Maybe this is something to be scheduled for version 2.0 when we break other things, too.

@TurekBot
Copy link
Contributor

TurekBot commented Dec 21, 2018

Ooh!

Maybe we can solve this using the default configuration!

Here's who lead me to that answer.

@nhajratw
Copy link
Author

i can't tell what default configuration does -- from the graph though, it seems like runtimeElements is the correct one...

@TurekBot
Copy link
Contributor

@nhajratw, I'm not sure, but according to this guy

the default configuration extendsFrom runtime, runtimeOnly, implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants