feat: ignore not-word string

edvardchen · Oct 10, 2019 · 1752cbe · 1752cbe
1 parent 077e682
commit 1752cbe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -52,9 +52,10 @@ module.exports = {
       parserServices,
       options: [option]
     } = context;
-    const whitelists = ((option && option.ignore) || []).map(
-      item => new RegExp(item)
-    );
+    const whitelists = [
+      /^[^A-Za-z]+$/, // ignore not-word string
+      ...((option && option.ignore) || [])
+    ].map(item => new RegExp(item));
 
     const calleeWhitelists = generateCalleeWhitelists(option);
     const message = 'disallow literal string';

diff --git a/tests/lib/rules/no-literal-string.js b/tests/lib/rules/no-literal-string.js
@@ -53,6 +53,8 @@ ruleTester.run('no-literal-string', rule, {
     { code: 'const a = require(["hello"]);' },
     { code: 'const a = require(["hel" + "lo"]);' },
     { code: 'const a = 1;' },
+    { code: 'const a = "?";' },
+    { code: `const a = "0123456789!@#$%^&*()_+|~-=\`[]{};':\\",./<>?";` },
     { code: 'i18n("hello");' },
     { code: 'dispatch("hello");' },
     { code: 'store.dispatch("hello");' },