Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs in product table fixed & form changes in settings and enrollment #43

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Oct 5, 2023

Description

Some issues that were occurring in the order when adding more products have been resolved, where the product table was experiencing visual glitches. Additionally, some modifications have been made to the CSS of the forms in the settings. The 'client secret' field now has its value hidden, and tooltips have been added to the checkboxes in the enrollment form.

Additional information

An important point to mention is that, in this case, it's preferable to keep the Client Secret as a 'password' and not display characters initially for security reasons (even though the token, being lengthy, adds a layer of security). It's better to keep it hidden. Another reason is to avoid having to insert JavaScript code because with HTML, it becomes complex to have a visible field for the user with a value like 'ABCD***HIJK' without modifying the form's behavior. This is because there needs to be both a hidden input and a visible input, which can potentially lead to conflicts when modifying the value.

This is what an order with more than one product looks like:
image

This is how the Client Secret is being displayed:

image

These are the tooltips for checkboxes in the Enrollment form:

image

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2
Copy link
Contributor Author

@MaferMazu @andres-arango-aptitude can you check this, please?

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@julianramirez2 julianramirez2 merged commit ddaaba7 into main Oct 5, 2023
3 checks passed
@felipemontoya felipemontoya deleted the frontend-mods branch March 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants