Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handler of fatal error in settings page corrected #38

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

julianramirez2
Copy link
Contributor

Description

Fixed an issue where a WordPress fatal error occurred when there was an error in the form information on the plugin's settings page, causing a severe disruption in the workflow. Now, the error is displayed as a card above the form. to the description of corresponding configuration changes. Remember to correctly annotate these
changes.

Testing instructions

Go to the staging and trigger an error by entering incorrect information in the form and attempting to generate a new token.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2
Copy link
Contributor Author

@MaferMazu @andres-arango-aptitude can you check this, please?

Copy link

@andres-arango-aptitude andres-arango-aptitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@julianramirez2 julianramirez2 merged commit c979f0b into main Sep 12, 2023
@felipemontoya felipemontoya deleted the show-error-fix branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants