Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual token generation #25

Merged
merged 11 commits into from
Aug 28, 2023
Merged

feat: manual token generation #25

merged 11 commits into from
Aug 28, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Aug 25, 2023

Description

The option to generate an authentication token manually is enabled in the plugin's configuration form. This functionality is powered by the external dependency Guzzle, which streamlines the way we handle HTTP requests. This functionality uses the form information fields to perform the token generation, it requires the correct identification to be used.

A new class named 'Openedx_Woocommerce_Plugin_Api_Calls' has been included in the development of this feature. We will use this class as a main file for making the necessary HTTP calls in the plugin processes, ensuring decoupling and scalability.

Testing instructions

To test it, navigate to the plugin settings at Settings -> Open Edx Sync and click the 'Generate JWT Token' button.

Additional information

The necessary dependencies have been added to the repository, as having these dependencies ready is essential for users to make proper use of the plugin upon installation.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2
Copy link
Contributor Author

@MaferMazu @andres-arango-aptitude Can you check this, please?

MaferMazu
MaferMazu previously approved these changes Aug 28, 2023
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I disagree with adding the requirements this way, but for now, it's okay.

@MaferMazu MaferMazu added this to the WooCommerce Integration milestone Aug 28, 2023
@MaferMazu MaferMazu linked an issue Aug 28, 2023 that may be closed by this pull request
@MaferMazu MaferMazu linked an issue Aug 28, 2023 that may be closed by this pull request
@julianramirez2 julianramirez2 merged commit 66b2ea9 into main Aug 28, 2023
@felipemontoya felipemontoya deleted the token-generator branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

["FEAT"] Generate a JWT token with the setting info
2 participants