Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enrollment crud operations working correctly #15

Merged
merged 13 commits into from
Jul 21, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Jul 19, 2023

Description

The CRUD operation of the form was adjusted to work correctly in terms of data persistence, the ability to modify and delete records, and ensuring that the information updates accordingly. Moreover, any values that need to be changed (e.g., the title of the Enrollment Request) will be updated based on the fields that are modified. Additionally, unused code was removed to maintain clean code for the current tasks.

Testing instructions

To test, simply access the plugin, create a new Enrollment Request, verify that it was saved correctly, and perform tests by modifying the existing variables to ensure that these changes persist.

Additional information

The 'username' field has been removed, and only the 'email' field remains as the identifier.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2 julianramirez2 requested a review from MaferMazu July 19, 2023 18:13
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and works as I expected.

@julianramirez2 julianramirez2 merged commit ab972ec into main Jul 21, 2023
@felipemontoya felipemontoya deleted the crud-enrollment-object branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants