From fbe0312a326693a81426760aab6ff8341fdb8c7c Mon Sep 17 00:00:00 2001 From: Ed Savage Date: Wed, 27 Nov 2024 16:28:58 +1300 Subject: [PATCH] [ML] Remove deprecated sort from reindex operation Sort in reindex is deprecated. This PR naively removes its use from within the reindexing step of dataframe analytics. Although this doesn't appear to have broken fundamental functionality, creating this PR as a draft initially to smoke out any unforeseen consequences. --- .../elasticsearch/xpack/ml/dataframe/steps/ReindexingStep.java | 1 - 1 file changed, 1 deletion(-) diff --git a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/steps/ReindexingStep.java b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/steps/ReindexingStep.java index 0ccdd1eb64601..5a1289e25fb4c 100644 --- a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/steps/ReindexingStep.java +++ b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/steps/ReindexingStep.java @@ -147,7 +147,6 @@ protected void doExecute(ActionListener listener) { reindexRequest.setSourceQuery(config.getSource().getParsedQuery()); reindexRequest.getSearchRequest().allowPartialSearchResults(false); reindexRequest.getSearchRequest().source().fetchSource(config.getSource().getSourceFiltering()); - reindexRequest.getSearchRequest().source().sort(SeqNoFieldMapper.NAME, SortOrder.ASC); reindexRequest.setDestIndex(config.getDest().getIndex()); // We explicitly set slices to 1 as we cannot parallelize in order to have the incremental id