Skip to content

Commit

Permalink
[ML] Remove deprecated sort from reindex operation
Browse files Browse the repository at this point in the history
Sort in reindex is deprecated. This PR naively removes its use from
within the reindexing step of dataframe analytics.

Although this doesn't appear to have broken fundamental functionality,
creating this PR as a draft initially to smoke out any unforeseen
consequences.
  • Loading branch information
edsavage committed Nov 27, 2024
1 parent c5d155e commit fbe0312
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ protected void doExecute(ActionListener<StepResponse> listener) {
reindexRequest.setSourceQuery(config.getSource().getParsedQuery());
reindexRequest.getSearchRequest().allowPartialSearchResults(false);
reindexRequest.getSearchRequest().source().fetchSource(config.getSource().getSourceFiltering());
reindexRequest.getSearchRequest().source().sort(SeqNoFieldMapper.NAME, SortOrder.ASC);
reindexRequest.setDestIndex(config.getDest().getIndex());

// We explicitly set slices to 1 as we cannot parallelize in order to have the incremental id
Expand Down

0 comments on commit fbe0312

Please sign in to comment.