Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reader view, navigation (TOC), "title"-only headings should not be clickable, should be inert. #520

Closed
danielweck opened this issue Aug 1, 2019 · 3 comments

Comments

@danielweck
Copy link
Member

danielweck commented Aug 1, 2019

Links without destination hrefs are correctly rendered (visually differentiated), however they should also be totally inert. Right now, they respond to mouse hover, display a hand cursor which indicates clickability. Nothing happens when clicking. However, when using the keyboard the links can be activated and a web browser window is opened to load the external link!! (because of undefined value at the end ... not sure what it going on exactly, but it's a bug :)

Compare Thorium / readium-desktop with r2-testapp-js:

ThoriumNav1

ThoriumNav2

@danielweck
Copy link
Member Author

danielweck commented Aug 1, 2019

Test file: moonstone.epub from https://1drv.ms/f/s!An5Z79wj5AZBgpFAxdv8z4Fo_z3ijw

See:
w3c/epub-specs#1283 (comment)

@danielweck
Copy link
Member Author

Interestingly, good old Readium1 web/cloud reader renders the TOC with clickable and usable top-level chapter links:

ThoriumNav3

@danielweck danielweck changed the title reader view, navigation (TOC), "title"-only headings should not be clickable reader view, navigation (TOC), "title"-only headings should not be clickable, should be inert. Aug 1, 2019
@danielweck
Copy link
Member Author

These ones are a variant with a different TOC:
http://www.feedbooks.com/book/3311/the-moonstone
https://www.gutenberg.org/ebooks/155
In this case, the headers are clickable and function as normal links (they should not be inert, because their href is valid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant