Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing label translations: "Cancel" "Oui" and "Non" #128

Closed
danielweck opened this issue Mar 28, 2018 · 4 comments
Closed

missing label translations: "Cancel" "Oui" and "Non" #128

danielweck opened this issue Mar 28, 2018 · 4 comments

Comments

@danielweck
Copy link
Member

This commit fba51fc for the in-progress Pull Request #126 adds a number of missing SVG <title> translations (see related issues #102 #103 #104).

Now, I have also noticed hard-coded label="Oui|Non|Cancel in App.tsx ( https://github.com/edrlab/readium-desktop/blob/develop/src/renderer/components/App.tsx ) and AppToolbar.tsx ( https://github.com/edrlab/readium-desktop/blob/develop/src/renderer/components/AppToolbar.tsx ).

@tofi86
Copy link
Contributor

tofi86 commented Apr 2, 2018

This is the following issue, right?

bildschirmfoto 2018-04-02 um 13 25 45
bildschirmfoto 2018-04-02 um 13 31 44

@danielweck
Copy link
Member Author

Hello Tobias, I think some of the UI translation bugs have already been resolved in this ongoing Pull Request (evolving branch in a fork of this repository):
#126
Perhaps this will affect your Pull Requests that currently target the develop branch (or erroneously, master ;) ... to be determined.

@tofi86
Copy link
Contributor

tofi86 commented Apr 2, 2018

Alright, will looking forward to see the changes implemented...

@MyDK
Copy link

MyDK commented Jun 21, 2018

Hi Daniel
I just tested ReadiumDesktop.Setup.1.0.0-alpha.2
The language issue is still present in both English and German "Import" and "Delete" windows.
import-wrong-language-on-bottons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants