Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http proxy documentation #56

Closed
panaC opened this issue May 1, 2024 · 6 comments
Closed

Add http proxy documentation #56

panaC opened this issue May 1, 2024 · 6 comments

Comments

@panaC
Copy link
Member

panaC commented May 1, 2024

edrlab/thorium-reader@994188c

@panaC
Copy link
Member Author

panaC commented May 2, 2024

@panaC
Copy link
Member Author

panaC commented May 2, 2024

@gautierchomel
Copy link
Member

Not sure what is expected here.

@gautierchomel
Copy link
Member

I understand that the original issue Thorium behind a proxy : not working #1904 is now fixed, so I see nothing to document for the user.

@danielweck
Copy link
Member

Hello @gautierchomel the Thorium documentation could mention the environment variables NO_PROXY, HTTPS_PROXY, HTTP_PROXY, ALL_PROXY, etc.

https://github.com/Rob--W/proxy-from-env?tab=readme-ov-file#environment-variables

This is how a user-defined proxy gets picked-up by Thorium, or more precisely by the underlying library:

https://github.com/TooTallNate/proxy-agents/tree/main/packages/proxy-agent

@gautierchomel
Copy link
Member

This is a very technical information that seems to be already available in the thorium reader repo readme Proxy server support section.

@gautierchomel gautierchomel reopened this Dec 5, 2024
@edrlab edrlab locked and limited conversation to collaborators Dec 5, 2024
@gautierchomel gautierchomel converted this issue into discussion #133 Dec 5, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants