Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building fails #37

Closed
Sozialarchiv opened this issue Sep 2, 2024 · 1 comment · Fixed by #38
Closed

Building fails #37

Sozialarchiv opened this issue Sep 2, 2024 · 1 comment · Fixed by #38

Comments

@Sozialarchiv
Copy link
Contributor

Sozialarchiv commented Sep 2, 2024 •
edited
Loading

@neSpecc

The workflow fails because it is using node 16.
https://github.com/editor-js/underline/blob/master/.github/workflows/npm-publish.yml

Other packages have a complete other workflow file:
https://github.com/editor-js/table/blob/master/.github/workflows/npm-publish.yml

Should I use the version from table or should I just update the node version in the current file?
@neSpecc
Copy link
Contributor

neSpecc commented Oct 5, 2024

Its better to use codex-team/github-workflows/.github/workflows/npm-publish-and-notify-reusable.yml

@Sozialarchiv Sozialarchiv mentioned this issue Oct 12, 2024
Merged
neSpecc added a commit that referenced this issue Oct 12, 2024
@neSpecc
Merge pull request #38 from Sozialarchiv/npm-publish-workflow
dffff78 
npm publish workflow updated, closes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

npm publish workflow updated, closes #37 Sozialarchiv/underline
2 participants
@neSpecc @Sozialarchiv