Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<memory_resource> not found on linux ci #39

Open
edhebi opened this issue Jun 22, 2020 · 5 comments
Open

<memory_resource> not found on linux ci #39

edhebi opened this issue Jun 22, 2020 · 5 comments

Comments

@edhebi
Copy link
Owner

edhebi commented Jun 22, 2020

Might be a CI specific problem or not, gotta test. #38 is dependent on this one getting fixed

@edhebi
Copy link
Owner Author

edhebi commented Jun 22, 2020

This is the 1st run where it breaks: https://github.com/Edhebi/cpp-sdl2/actions/runs/143202036

@edhebi
Copy link
Owner Author

edhebi commented Jun 22, 2020

Reproduced on an actual linux machine, it seems to be due to gcc being too old. Apparently, <memory_resource> requires gcc>=9
https://godbolt.org/z/_YG6ji

@edhebi
Copy link
Owner Author

edhebi commented Jun 22, 2020

@Ybalrid Interested by your opinion on this one : should we mandate gcc9, or conditionaly define the memory resource implementation on __has_include(<memory_resource>) ? we don't actually use the memory resource anywhere else.

@edhebi
Copy link
Owner Author

edhebi commented Jun 22, 2020

fwiw, this'd allow this part to compile on gcc starting from 7.5 at least (the one on the CI and latest on ubuntu repos):
https://godbolt.org/z/vjx5Px

@Ybalrid
Copy link
Collaborator

Ybalrid commented Jun 22, 2020

If you want to maintain codepath with and without this header, it's your call not mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants