Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add device-opc-ua documentation #1427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jiekechoo
Copy link
Member

@jiekechoo jiekechoo commented Feb 21, 2025

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)


## Environment

You can use any operating system that can install docker and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use any operating system that can install docker and
You can use any operating system that can install docker and

Copy link
Contributor

@jumpingliu jumpingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor fixes

@jumpingliu jumpingliu self-requested a review February 25, 2025 02:45
Copy link
Contributor

@jumpingliu jumpingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumpingliu
Copy link
Contributor

jumpingliu commented Feb 25, 2025

Hi @jiekechoo, please fix the title of the latest commit, https://github.com/Ezard/semantic-prs. thanks

For example, the commit should look like: fix: address request change

Co-authored-by: Melody <[email protected]>
Signed-off-by: Jieke Choo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants