treewide: prepare separation of node installers #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
force-pushed
the
msanft/runtime-class-files-msft
branch
3 times, most recently
from
277f877 to
ebdbf1a
Compare
This migrates the runtime-class-files to the new directory structure, as they only contain Microsoft-specific components and thus should not live in the shared space.
msanft
force-pushed
the
msanft/runtime-class-files-msft
branch
from
ebdbf1a to
53a71bf
Compare
This also pulls out the node installer image to the new directory structure, as it also only holds Microsoft-specific components. A future refactoring should make this share the lowest layer (i.e. the node installer binary itself) between flavour-specific node installers.
msanft
force-pushed
the
msanft/runtime-class-files-msft
branch
from
53a71bf to
07b653f
Compare
katexochen
requested changes
Jun 20, 2024
| @@ -48,7 +48,7 @@ jobs: | |||
| just get-credentials | |||
| - name: Build and prepare deployments | |||
| run: | | |||
| just node-installer | |||
| just microsoft-node-installer | |||
There was a problem hiding this comment.
please change to node-installer-microsoft, which is more intuitive for tab completion.
| @@ -42,12 +42,12 @@ func NodeInstaller(namespace string) *NodeInstallerConfig { | |||
| ). | |||
| WithTemplate(PodTemplateSpec(). | |||
| WithLabels(map[string]string{"app.kubernetes.io/name": name}). | |||
| WithAnnotations(map[string]string{"contrast.edgeless.systems/pod-role": "contrast-node-installer"}). | |||
| WithAnnotations(map[string]string{"contrast.edgeless.systems/pod-role": "contrast-node-installer-microsoft"}). | |||
There was a problem hiding this comment.
Why do we need to change this?
|
Closing in favor of #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support multiple deployment "flavours" (i.e. AKS and bare-metal QEMU on TDX), we need to provide separate node installer deployments, as both deployment scenarios require different components to be installed on the hosts. This prepares this separation, by moving the Microsoft-specific runtime-class-files into the
microsoftpackage set, and including the "flavour" of the deployment in the node installer image name.