Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: adopt bzlmod #3116

Merged
merged 17 commits into from
May 23, 2024
Merged

bazel: adopt bzlmod #3116

merged 17 commits into from
May 23, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented May 22, 2024 •
edited
Loading

Context

Bzlmod is the new dependency management system of Bazel. It works in a similar way as go mod.

Proposed change(s)

  • migrate most external Bazel dependencies to bzlmod

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@malt3 malt3 added the no changelog Change won't be listed in release changelog label May 22, 2024
@malt3 malt3 added this to the v2.17.0 milestone May 22, 2024
@netlify Netlify

This comment was marked as off-topic.

Sign in to view
@malt3 malt3 force-pushed the bazel/adopt-bzlmod branch from 5a9965c to 0b36920 Compare May 22, 2024 09:00
daniel-weisse
daniel-weisse reviewed May 22, 2024
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
Will this require any changes to our renovate.json?

disk-mapper/recoverproto/recover.pb.go Show resolved Hide resolved
@malt3
Copy link
Contributor Author

malt3 commented May 22, 2024 •
edited
Loading

nice Will this require any changes to our renovate.json?

As far as I can tell, renovate already natively supports bzlmod.

Although I need to (and will) test if the bazel-module manager works as intended once this hits the main branch.

@malt3 malt3 force-pushed the bazel/adopt-bzlmod branch 2 times, most recently from 52e8722 to ecbfd6e Compare May 22, 2024 09:42
@malt3 malt3 mentioned this pull request May 22, 2024
Closed
1 task
@malt3 malt3 marked this pull request as ready for review May 22, 2024 10:44
@malt3 malt3 requested a review from burgerdev May 22, 2024 10:49
burgerdev
burgerdev reviewed May 22, 2024
View reviewed changes
.bazelrc Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
3rdparty/bazel/com_github_google_go_tpm_tools/com_github_google_go_tpm_tools.need Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the bazel/adopt-bzlmod branch from ecbfd6e to a6097fc Compare May 22, 2024 11:27
@malt3
bazel: limit concurrency of mkosi_image rule
7c0dfa7 
The mkosi_image rule uses a lot of memory.
In order to allow higher levels of concurrency,
such as `bazel build --jobs 128`, we need to more accurately model the
amount of CPU and memory required.
@malt3 malt3 force-pushed the bazel/adopt-bzlmod branch 4 times, most recently from e0412fb to 5f79bc7 Compare May 22, 2024 13:51
malt3 added 2 commits May 22, 2024 16:12
@malt3
bazel: commit bzlmod lockfile
d9c7c07 
While it does have some quirks before Bazel 7.2, it is still vital for security.
@malt3
tidy: document MODULE.bazel.lock maintencance
2c82882
@malt3 malt3 force-pushed the bazel/adopt-bzlmod branch from 5f79bc7 to 2c82882 Compare May 22, 2024 14:12
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
bootstrapper/initproto 0.00% 0.00% 🚧
bootstrapper/internal/initserver 22.80% 22.80% 🚧
bootstrapper/internal/joinclient 39.70% 39.70% 🚧
cli/internal/cmd 41.00% 41.00% 🚧
csi/kms 18.00% 18.00% 🚧
debugd/internal/cdbg/cmd 0.00% 0.00% 🚧
debugd/internal/debugd/deploy 28.10% 28.30% ↗️
debugd/internal/debugd/server 36.20% 36.20% 🚧
debugd/service 0.00% 0.00% 🚧
disk-mapper/internal/recoveryserver 38.00% 38.00% 🚧
disk-mapper/internal/rejoinclient 27.50% 27.50% 🚧
disk-mapper/recoverproto 0.00% 0.00% 🚧
hack/bazel-deps-mirror 0.00% 0.00% 🚧
hack/bazel-deps-mirror/internal/bazelfiles 75.00% 75.00% ↔️
internal/constellation 19.00% 19.00% 🚧
internal/grpc/atlscredentials 18.70% 18.40% ↘️
internal/grpc/dialer 25.30% 25.30% 🚧
internal/logger 0.00% 0.00% 🚧
internal/versions/components 44.30% 44.30% 🚧
joinservice/internal/kms 15.90% 15.90% 🚧
joinservice/internal/server 21.30% 21.30% 🚧
joinservice/joinproto 0.00% 0.00% 🚧
keyservice/internal/server 15.90% 15.90% 🚧
keyservice/keyserviceproto 0.00% 0.00% 🚧
operators/constellation-node-operator/internal/upgrade 0.00% 0.00% 🚧
s3proxy/internal/kms 15.90% 15.90% 🚧
upgrade-agent/internal/server 9.60% 9.60% 🚧
upgrade-agent/upgradeproto 0.00% 0.00% 🚧
verify/server 43.30% 43.30% 🚧
verify/verifyproto 0.00% 0.00% 🚧

@malt3 malt3 requested a review from daniel-weisse May 23, 2024 06:44
@malt3 malt3 merged commit b86faad into main May 23, 2024
38 checks passed
@malt3 malt3 deleted the bazel/adopt-bzlmod branch May 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@burgerdev burgerdev burgerdev approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

@katexochen katexochen Awaiting requested review from katexochen katexochen is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @burgerdev @daniel-weisse