Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS] Accept ph:// assets for camera-roll uploads #157

Closed
vforvasile opened this issue Jul 20, 2021 · 1 comment
Closed

[IOS] Accept ph:// assets for camera-roll uploads #157

vforvasile opened this issue Jul 20, 2021 · 1 comment

Comments

@vforvasile
Copy link

Hello @edeckers!

Is your feature request related to a problem? Please describe.
Would be very nice to be able to upload ph:// files without extra steps.

Describe the solution you'd like
I can't really describe the solution. Someone opened a PR in another library a while ago related to ph:// uploads

Describe alternatives you've considered
Copy a temporary file with react-native-fs then upload the temporary file then delete temporary file after upload is finished

Have a nice day!

@edeckers
Copy link
Owner

edeckers commented Jul 27, 2021

Hey, thank you for your request! While I do understand your motivation for wanting this feature, I avoid adding any file system related feature by design: it seems to me that predecessors of react-native-blob-courier (e.g. rn-fetch-blob) tried to include both file system access and HTTP transfer functionality, which is what bit them eventually. Either because the library became too big to maintain, because Android moved to Scoped Storage, etc.

Therefore the alternative approach you described is exactly the way react-native-blob-courier is intended to be used. Which might be cumbersome and even suboptimal from a resource usage perspective, but it keeps react-native-blob-courier simple, focused and maintainable.

If you're looking for a combination of both file system access and HTTP transfers you should check out react-native-file-access, which is an initiative that just like react-native-blob-courier started in the wake of the rn-fetch-blob discontinuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants