Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubler build interactive behaviour difference: continues on errors in configure_bob() #213

Open
berney opened this issue Sep 11, 2022 · 1 comment

Comments

@berney
Copy link
Contributor

berney commented Sep 11, 2022

Currently for me the kubler/bob-musl image is failing to build.

In the builder/bob-musl/build.sh configure_bob() one of the steps is failing (I opened a separate issue #214 for this).

If I run kubler build -i kubler/bob-musl and then kubler-build-root the same error occurs, but instead of stopping at the failed command the build continues to execute all the commands in the configure_bob() function.

I think the behaviour in interactive mode should stop on the failed command like in non-interactive mode. Otherwise the terminal can have a lot of output and the build can look successful (it may even be successful, if the error didn't impact it).

@edannenberg
Copy link
Owner

This might be a bit of an edge case for build containers in interactive mode. Interactive mode is not running Bash in super strict mode as that might also exit the build container completely on errors, which is most likely not what you want. Not sure this can be resolved easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants