Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that numerical component of an EDAM concept ID is unique #18

Open
joncison opened this issue Mar 3, 2020 · 1 comment
Open

Check that numerical component of an EDAM concept ID is unique #18

joncison opened this issue Mar 3, 2020 · 1 comment
Assignees
Labels
done - pending review Issue / check is implemented, but a review of it is needed.

Comments

@joncison
Copy link
Contributor

joncison commented Mar 3, 2020

The numerical component of an EDAM concept ID is duplicated in some other concept ID.

@joncison joncison added the done - pending review Issue / check is implemented, but a review of it is needed. label Mar 26, 2020
@joncison joncison self-assigned this Mar 26, 2020
@joncison
Copy link
Contributor Author

done, see https://github.com/edamontology/edamverify/blob/master/queries/iDNumericalDuplication.ipynb

would benefit from a review at some stage @albangaignard @hmenager

an interesting footnote on this one (reflected in the code) is that EDAM subsets - being defined as XML attributes in the RDF/XML - are not amenable e.g. to FILTER SPARQL queries, which only work on XML element values. It took me a while to realise this! Had it been otherwise, more of the logic could have been put in the SPARQL query. Correct me if I'm wrong here, Alban!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done - pending review Issue / check is implemented, but a review of it is needed.
Projects
None yet
Development

No branches or pull requests

1 participant