Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bool-flag side schema #98

Open
alnoki opened this issue Mar 20, 2023 · 1 comment
Open

Simplify bool-flag side schema #98

alnoki opened this issue Mar 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@alnoki
Copy link
Member

alnoki commented Mar 20, 2023

Presently, Econia uses ASK, BID, BUY, and SELL with side and direction fields, respectively.

Instead, it is proposed that fields be switched to is_maker and is_ask to avoid having to synchronize bool flags.
@alnoki alnoki added the enhancement New feature or request label Mar 20, 2023
@alnoki
Copy link
Member Author

alnoki commented Nov 20, 2023

is_buy_side: uses buy/sell, which is simplest terminology

Buy is fewer letters than sell, and also correlates with optimism vs pessisimism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alnoki