Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of multi-word file paths #34

Open
jclem opened this issue Aug 20, 2024 · 0 comments
Open

Incorrect parsing of multi-word file paths #34

jclem opened this issue Aug 20, 2024 · 0 comments

Comments

@jclem
Copy link

jclem commented Aug 20, 2024

The following is a valid git diff for a file that has whitespace in its path:

diff --git c/foo bar w/foo bar
new file mode 100644
index 0000000..e69de29

This package parses it as the following:

[
  {
    hunks: [],
    oldEndingNewLine: true,
    newEndingNewLine: true,
    oldPath: 'foo',
    newPath: 'r',
    newMode: '100644',
    oldRevision: '0000000',
    newRevision: 'e69de29',
    type: 'modify'
  }
]

Instead, oldPath and newPath should both be 'foo bar'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant