Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop official support for non modular vms #522

Closed
laeubi opened this issue Jan 9, 2022 · 5 comments · Fixed by #920
Closed

Drop official support for non modular vms #522

laeubi opened this issue Jan 9, 2022 · 5 comments · Fixed by #920
Milestone
3.0

Comments

@laeubi
Copy link
Member

laeubi commented Jan 9, 2022

We currently have one test that explicitly requires a Java-8 VM in toolchains.

As Java 8 is EOL for a long time and we are about to switch to Java 17 maybe at end of year I think we should drop official support for non modular VMs.

That would mean we

  1. remove the test that currently requires Java 8
  2. do no longer support bugs/regressions that target Java 8 unless a patch is provided that do not require us to maintain legacy code
@laeubi laeubi added this to the 3.0 milestone Jan 9, 2022
@laeubi laeubi mentioned this issue Mar 17, 2022
Merged
@akurtakov
Copy link
Member

I am all for that. Considering the fact Java 23 (Sep 2023) will be yet another LTS version supporting pre Java 11. We should go by LTS vesions thus support for pre Java 11 should be considered "selfsupport".

@akurtakov
Copy link
Member

@laeubi Do you remember the exact test requiring Java 8 JVM ? I would like to get rid of it immediately.

@laeubi
Copy link
Member Author

laeubi commented Apr 26, 2022

I think it is

https://github.com/eclipse/tycho/blob/master/tycho-its/src/test/java/org/eclipse/tycho/test/compiler/JdtBreeJava8Test.java

we then should also remove toolchain here https://github.com/eclipse/tycho/blob/master/toolchains-gh.xml and java 8 setup here https://github.com/eclipse/tycho/blob/16cb813ac8f13eea42e7ceaa8d80a9fc6965e368/.github/workflows/maven.yml#L26 that will revel if there are more tests requiring java 8

akurtakov added a commit to akurtakov/tycho that referenced this issue Apr 27, 2022
@akurtakov
Drop tests that need Java 8 explicitly to succeed
1c077f3 
Requiring Java 8 is no longer sane requirement now that there are 2 more
Java LTS versions.
Fixes eclipse-tycho#522 .
@akurtakov akurtakov mentioned this issue Apr 27, 2022
Merged
akurtakov added a commit that referenced this issue Apr 28, 2022
@akurtakov
Drop tests that need Java 8 explicitly to succeed
0dfbd59 
Requiring Java 8 is no longer sane requirement now that there are 2 more
Java LTS versions.
Fixes #522 .
@laeubi
Copy link
Member Author

laeubi commented Apr 28, 2022

Do you like to add a note to the migration guide that we do no longer test/maintain VMs < 9

@akurtakov
Copy link
Member

Done via 9ae3f04

@laeubi laeubi mentioned this issue Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Drop tests that need Java 8 explicitly to succeed akurtakov/tycho
2 participants
@akurtakov @laeubi