Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Axis Line optional #274

Closed
MatthewKhouzam opened this issue Nov 17, 2021 · 5 comments
Closed

Make Axis Line optional #274

MatthewKhouzam opened this issue Nov 17, 2021 · 5 comments
Assignees

Comments

@MatthewKhouzam
Copy link
Contributor

MatthewKhouzam commented Nov 17, 2021

I am exploring for trace compass different ways to make the data easier to read

Here is an example chart with a pair of custom charts. A style that is becoming more popular now is a minimalist chart where the Y axis bar is invisible.
Example with Y Axis line:
image
And without
image
This image is an example of what I am looking for, and to get it, we just need to comment out one line. Do you have any API suggestions to make this make sense?

@eselmeister
Copy link
Contributor

@MatthewKhouzam Am I right, you would like to disable drawing the black line of the Axis?

Bildschirmfoto von 2021-11-19 06-33-27

@MatthewKhouzam
Copy link
Contributor Author

@eselmeister As usual, you are correct. It's trivial to do in the code, the API is the tricky part.

@eselmeister
Copy link
Contributor

@MatthewKhouzam Let me inspect it. I'm pretty confident that extending the IChartSettings by an extra option will do the trick.

@eselmeister eselmeister self-assigned this Nov 21, 2021
@eselmeister
Copy link
Contributor

I found a solution. The code will be merged today.

@eselmeister
Copy link
Contributor

@MatthewKhouzam Done :-)

The axis lines can be now activated/deactivated for each axis separately via the method setDrawAxisLine(...), e.g.:

IChartSettings chartSettings = scrollableChart.getChartSettings();
chartSettings.getPrimaryAxisSettingsX().setDrawAxisLine(false);
scrollableChart.applySettings(chartSettings);

Have a look at the demo chart examples:
org.eclipse.swtchart.extensions.examples.charts.DemoChart

Bildschirmfoto von 2021-11-21 11-01-14

Bildschirmfoto von 2021-11-21 11-01-26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants