Allow extensions to contribute to WorkspaceService #966
Conversation
mickaelistria
force-pushed
the
workspaceService
branch
from
6970018 to
38895d5
Compare
|
|
||
| import org.eclipse.lsp4j.DidChangeWorkspaceFoldersParams; | ||
|
|
||
| public interface IWorkspaceServiceParticipant { |
|
|
||
| public interface IWorkspaceServiceParticipant { | ||
|
|
||
| public void didChangeWorkspaceFolders(DidChangeWorkspaceFoldersParams params); |
| @@ -32,6 +32,7 @@ | |||
| import org.eclipse.lemminx.services.extensions.save.ISaveContext.SaveContextType; | |||
| import org.eclipse.lemminx.uriresolver.URIResolverExtensionManager; | |||
| import org.eclipse.lsp4j.InitializeParams; | |||
| import org.eclipse.lsp4j.services.WorkspaceService; | |||
| @@ -196,6 +199,15 @@ public void doSave(ISaveContext saveContext) { | |||
| return symbolsProviderParticipants; | |||
| } | |||
|
|
|||
| /** | |||
| * @return | |||
| @@ -356,6 +368,22 @@ public void registerSymbolsProviderParticipant(ISymbolsProviderParticipant symbo | |||
| public void unregisterSymbolsProviderParticipant(ISymbolsProviderParticipant symbolsProviderParticipant) { | |||
| symbolsProviderParticipants.remove(symbolsProviderParticipant); | |||
| } | |||
|
|
|||
| /** | |||
| } | ||
|
|
||
| /** | ||
| * @param workspaceServiceParticipant |
|
|
||
| @BeforeEach | ||
| public void initializeLanguageService() { | ||
| this.server = new XMLLanguageServer(); |
There was a problem hiding this comment.
write just:
this.server = new MockXMLLanguageServer()
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class WorkspaceServiceParticipantTest { |
| @@ -0,0 +1,17 @@ | |||
| /** | |||
There was a problem hiding this comment.
Please add contributors in the header:
/*******************************************************************************
* Copyright (c) 2021 Red Hat Inc. and others.
* All rights reserved. This program and the accompanying materials
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v20.html
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* Red Hat Inc. - initial API and implementation
*******************************************************************************/
There was a problem hiding this comment.
FWIW, it's been clarified by EMO that according to latest version of EDP those Contributors block are not at all mandatory for Eclipse projects.
Currently supports didChangeWorkspaceFolders Signed-off-by: Mickael Istria <[email protected]>
mickaelistria
force-pushed
the
workspaceService
branch
from
38895d5 to
2b4e570
Compare
|
I think my last patch does cover all concerns you expressed. |
|
Thanks @mickaelistria ! |
|
Thanks a lot for the review! Do you have an estimation of when is next release going to happen? Depending on the release date, we may merge the LemMinX-Maven change leveraging this API right now or later. |
You are welcome!
We will do a release as soon as the binary stuff will be available by @datho7561 |
Currently supports
didChangeWorkspaceFolders
Signed-off-by: Mickael Istria [email protected]