Display no hover if there is no documentation

[datho7561]

See redhat-developer/vscode-xml#258

Signed-off-by: David Thompson [email protected]

[angelozerr]

@datho7561 it should be better to fix this issue when documentation is generated. I have not tested but I think the correct fix is to move this block code https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/XMLGenerator.java#L235-L248 to https://github.com/eclipse/lemminx/blob/03ca39622411febbf13b2721886985e0bcaef44c/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/XMLGenerator.java#L233

For the test:

• fix the tests by adding some xs:appinfo in docAppinfo.xsd
• write test with empty documentation to check you return no hover.

[datho7561]

@angelozerr Thanks! The only issue is that this means the completion won't display anything if there is no doc:

If this is okay, I'll take this route. Otherwise, I think something more involved might be required.

[angelozerr]

Completion and Hover must have the same behavior to be consistent so yes its ok

[fbricon]

Given

<?xml version="1.0" encoding="UTF-8" ?>
<hazdoc xmlns="foo" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="foo ./foo.xsd">
<nodoc></nodoc>
</hazdoc>

and foo.xsd containing

<?xml version="1.0"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" 
  elementFormDefault="qualified" 
  xmlns="foo" 
  targetNamespace="foo">
  <xs:element name="hazdoc">
    <xs:annotation>
      <xs:appinfo> I haz appinfo</xs:appinfo>
      <xs:documentation source="version">3.0.0+</xs:documentation>
      <xs:documentation source="description">
        
        I haz doc
        
      </xs:documentation>
    </xs:annotation>
  </xs:element>
      <xs:element name="nodoc" type="xs:string">
        <xs:annotation>
          <xs:appinfo>    </xs:appinfo>
          <xs:documentation source="version">   </xs:documentation>
          <xs:documentation source="description">

          </xs:documentation>
        </xs:annotation>
      </xs:element>
</xs:schema>

The nodoc node should not have any hover, as all its docs are blank, yet it shows a Source link on hover, with no doc.

[datho7561]

Given

<?xml version="1.0" encoding="UTF-8" ?>
<hazdoc xmlns="foo" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="foo ./foo.xsd">
<nodoc></nodoc>
</hazdoc>

and foo.xsd containing

<?xml version="1.0"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" 
  elementFormDefault="qualified" 
  xmlns="foo" 
  targetNamespace="foo">
  <xs:element name="hazdoc">
    <xs:annotation>
      <xs:appinfo> I haz appinfo</xs:appinfo>
      <xs:documentation source="version">3.0.0+</xs:documentation>
      <xs:documentation source="description">
        
        I haz doc
        
      </xs:documentation>
    </xs:annotation>
  </xs:element>
      <xs:element name="nodoc" type="xs:string">
        <xs:annotation>
          <xs:appinfo>    </xs:appinfo>
          <xs:documentation source="version">   </xs:documentation>
          <xs:documentation source="description">

          </xs:documentation>
        </xs:annotation>
      </xs:element>
</xs:schema>

The nodoc node should not have any hover, as all its docs are blank, yet it shows a Source link on hover, with no doc.

Thanks for point this out! I fixed it and added a test case for it.

[angelozerr]

Works like a charm, great job @datho7561 !