Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display test names in a more user-friendly way #647

Merged
merged 1 commit into from
May 12, 2020

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Apr 20, 2020

No description provided.

@fbricon
Copy link
Contributor Author

fbricon commented Apr 20, 2020

@fbricon fbricon added build enhancement New feature or request and removed enhancement New feature or request labels Apr 22, 2020
@fbricon
Copy link
Contributor Author

fbricon commented Apr 22, 2020

@angelozerr @xorye worth it or not?

@fbricon fbricon self-assigned this Apr 22, 2020
@fbricon fbricon force-pushed the junit5-displayName branch from 929da81 to 3fb6216 Compare April 22, 2020 16:20
@fbricon fbricon force-pushed the junit5-displayName branch from 3fb6216 to e7873c9 Compare April 22, 2020 16:30
@fbricon
Copy link
Contributor Author

fbricon commented Apr 22, 2020

There, Class names unchanged, method names beautified:

https://ci.eclipse.org/lemminx/job/lemminx/view/change-requests/job/PR-647/lastCompletedBuild/testReport/org.eclipse.lemminx.uriresolver/CacheResourcesManagerTest/

Screen Shot 2020-04-22 at 6 50 36 PM

CLI build output:
Screen Shot 2020-04-22 at 6 49 44 PM

In Eclipse JUnit view, Class names and method names are beautified, but clicking on them links to proper locations:
Screen Shot 2020-04-22 at 6 53 22 PM

Nothing changes in vscode test view, seems they don't support @DisplayName

@xorye
Copy link

xorye commented May 8, 2020

I'm good with this being merged

@fbricon fbricon merged commit ead93d5 into eclipse-lemminx:master May 12, 2020
@fbricon fbricon deleted the junit5-displayName branch May 12, 2020 11:07
@fbricon fbricon added this to the 0.12.0 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants