Fixed file path issue on Windows #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasKomonen
force-pushed
the
fileCachePathFix
branch
2 times, most recently
from
def18ec to
d61da95
Compare
fbricon
reviewed
Apr 8, 2019
org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/utils/ProjectUtils.java
Outdated
Show resolved
Hide resolved
NikolasKomonen
force-pushed
the
fileCachePathFix
branch
3 times, most recently
from
c991829 to
400b503
Compare
fbricon
reviewed
Apr 8, 2019
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/FilesUtils.java
Outdated
Show resolved
Hide resolved
NikolasKomonen
force-pushed
the
fileCachePathFix
branch
2 times, most recently
from
4c0bd96 to
55321bf
Compare
fbricon
reviewed
Apr 8, 2019
org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/utils/ProjectUtils.java
Outdated
Show resolved
Hide resolved
NikolasKomonen
force-pushed
the
fileCachePathFix
branch
2 times, most recently
from
18e38b8 to
b1cb9ce
Compare
Fixes redhat-developer/vscode-xml#125 Signed-off-by: Nikolas K <[email protected]>
NikolasKomonen
commented
Apr 8, 2019
| assertEquals("~/Test/Folder", FilesUtils.normalizePath("./~/Test/Folder")); | ||
| assertEquals("/Folder", FilesUtils.normalizePath("/Test/../Folder")); | ||
| assertEquals(Paths.get(System.getProperty("user.home"), "Test", "Folder").toString(), FilesUtils.normalizePath("~/Test/Folder")); | ||
| assertEquals(Paths.get(separator, "Test", "~", "Folder").toString(), FilesUtils.normalizePath("/Test/~/Folder")); |
There was a problem hiding this comment.
@fbricon This test was failing for me on Windows, an extra \ was inserted at the beginning of the output of Paths.get(...) could you check if you have the same issue
|
@fbricon updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-xml#125