Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations found in base complex type not shown on hover #1268

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

mattbsox
Copy link
Contributor

@mattbsox mattbsox commented Aug 3, 2022

Fixes an issue where annotations found in base complex type elements were not displayed on hover.

See OpenLiberty/liberty-language-server#62

Signed-off-by: Matt Bowersox [email protected]

Copy link
Contributor

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me!

Peek 2022-08-04 15-21

System.lineSeparator() + //
"Source: [extendedComplexType.xsd](" + schemaURI + ")";

assertHover(xml, expected,r(0, 1, 0, 9));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code here

@mattbsox mattbsox force-pushed the complexTypeExtension branch from 20e0fa9 to b5c4e3c Compare August 4, 2022 20:31
@angelozerr angelozerr merged commit 9827ac2 into eclipse-lemminx:main Aug 5, 2022
@angelozerr
Copy link
Contributor

Thanks so much @mattbsox for your contribution.

Thanks @JessicaJHee for your review.

@angelozerr angelozerr added this to the 0.22.0 milestone Aug 5, 2022
@angelozerr angelozerr added the bug Something isn't working label Sep 28, 2022
@angelozerr angelozerr changed the title Checking base complex type for annotations Annotations found in base complex type not shown on hover Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants