Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCTYPE entities interfering with hover annotation display of tags / attributes #1212

Conversation

angelozerr
Copy link
Contributor

DOCTYPE entities interfering with hover annotation display of tags / attributes.

Fixes redhat-developer/vscode-xml#716

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

I need to write test but it should fix the issue redhat-developer/vscode-xml#716. The problem with this issue is when XSD is bound with file association and there are DTD internal, it loose the file association link. The PR should fix that and fixes too:

  • completion based on XSD:

image

  • go to type definition

image

@angelozerr angelozerr force-pushed the internal-dtd-fileassociation-both branch 2 times, most recently from 3e580dc to affc82a Compare June 2, 2022 05:24
@angelozerr angelozerr marked this pull request as ready for review June 2, 2022 06:40
@angelozerr angelozerr force-pushed the internal-dtd-fileassociation-both branch from affc82a to c6225f7 Compare June 2, 2022 07:32
@angelozerr
Copy link
Contributor Author

Tests are written now.Thanks @AlexXuChen for your review.

@angelozerr angelozerr merged commit 3d10a3a into eclipse-lemminx:master Jun 2, 2022
@angelozerr angelozerr added this to the 0.21.0 milestone Jun 2, 2022
@angelozerr angelozerr changed the title DOCTYPE entities interfering with hover annotation display of tags / attributes. DOCTYPE entities interfering with hover annotation display of tags / attributes Jun 29, 2022
@angelozerr angelozerr added the bug Something isn't working label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCTYPE entities interfering with hover annotation display of tags / attributes.
1 participant