Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate end element on apply completion if it exists #651

Closed
angelozerr opened this issue Apr 22, 2020 · 0 comments · Fixed by #652 or enxio/lsp4xml#37
Closed

Don't generate end element on apply completion if it exists #651

angelozerr opened this issue Apr 22, 2020 · 0 comments · Fixed by #652 or enxio/lsp4xml#37
Assignees
@angelozerr
Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Milestone
0.12.0

Comments

@angelozerr
Copy link
Contributor

To fix redhat-developer/vscode-xml#213 (comment) the apply completion (for XML and for XML based on a grammar) must generate the end element only if it needs.
@angelozerr angelozerr self-assigned this Apr 22, 2020
@angelozerr angelozerr added bug Something isn't working completion This issue or enhancement is related to completion support labels Apr 22, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone Apr 22, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 22, 2020
@angelozerr
Don't generate end element on apply completion if it exists
f98587b 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 22, 2020
@angelozerr
Don't generate end element on apply completion if it exists
eafa172 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
2728a29 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
c80db9e 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
b0e0b87 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
fe26010 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
b03c469 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Apr 23, 2020
Merged
angelozerr added a commit to angelozerr/lemminx that referenced this issue Apr 23, 2020
@angelozerr
Don't generate end element on apply completion if it exists
ae476f8 
Fixes eclipse-lemminx#651

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit that referenced this issue Apr 23, 2020
@angelozerr @fbricon
Don't generate end element on apply completion if it exists
d0a94fd 
Fixes #651

Signed-off-by: azerr <[email protected]>
@enxio enxio mentioned this issue Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Projects
None yet
Milestone
0.12.0
1 participant
@angelozerr