Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NPE in textDocument/definition in XSD files #488

Closed
fbricon opened this issue Jul 1, 2019 · 1 comment · Fixed by #489
Closed

Fixed NPE in textDocument/definition in XSD files #488

fbricon opened this issue Jul 1, 2019 · 1 comment · Fixed by #489
Assignees
@angelozerr
Labels
bug Something isn't working hyperlink XSD
Milestone
v0.8.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Jul 1, 2019

With an XSD document as simple as

<?xml version='1.0'?>
<xs:schema xmlns:xs='http://www.w3.org/2001/XMLSchema'>
</xs:schema>

In VS Code, when you ctrl+hover (or cmd+hover on Mac) over schema (to trigger textDocument/definition), an NPE is thrown by LSP4XML
@fbricon fbricon added the bug Something isn't working label Jul 1, 2019
@fbricon fbricon added this to the v0.8.0 milestone Jul 1, 2019
angelozerr added a commit that referenced this issue Jul 1, 2019
@angelozerr
NPE in textDocument/definition in XSD files
28b21f5 
Fix #488

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jul 1, 2019
Merged
@angelozerr
Copy link
Contributor

@fbricon please review #489

fbricon pushed a commit that referenced this issue Jul 1, 2019
@angelozerr @fbricon
NPE in textDocument/definition in XSD files
37ac075 
Fix #488

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr changed the title NPE in textDocument/definition in XSD files NPE in textDocument/definition in XSD files Jul 23, 2019
@angelozerr angelozerr changed the title NPE in textDocument/definition in XSD files Fixed NPE in textDocument/definition in XSD files Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working hyperlink XSD
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

NPE in textDocument/definition in XSD files eclipse-lemminx/lemminx
2 participants
@fbricon @angelozerr