Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed case sensitivity problems for element and attribute names #433

Closed
angelozerr opened this issue Jun 12, 2019 · 0 comments · Fixed by #434
Closed

Fixed case sensitivity problems for element and attribute names #433

angelozerr opened this issue Jun 12, 2019 · 0 comments · Fixed by #434
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
v0.8.0

Comments

@angelozerr
Copy link
Contributor

XML Element/Attribute names must be case sensitive. For instance if we have this xml

<a></A>

For example if we set the cursor in <a>, document highlight should not highlight </A>
angelozerr added a commit that referenced this issue Jun 12, 2019
@angelozerr
Element/Attribute names must be case sensitive (see #433)
bfbd210 
This PR fix #433 and avoid using String#toLowerCase() which creates a
lot of instances of String.
@angelozerr angelozerr mentioned this issue Jun 12, 2019
Merged
@angelozerr angelozerr added this to the v0.8.0 milestone Jun 12, 2019
angelozerr added a commit that referenced this issue Jun 14, 2019
@angelozerr
Element/Attribute names must be case sensitive (see #433)
beb7b68 
This PR fix #433 and avoid using String#toLowerCase() which creates a
lot of instances of String.
angelozerr added a commit that referenced this issue Jun 14, 2019
@angelozerr
Element/Attribute names must be case sensitive (see #433)
87d7341 
This PR fix #433 and avoid using String#toLowerCase() which creates a
lot of instances of String.
@angelozerr angelozerr self-assigned this Jun 28, 2019
@angelozerr angelozerr added the bug Something isn't working label Jul 23, 2019
@angelozerr angelozerr changed the title Element/Attribute names must be case sensitive Fixed case sensitivity problems for element and attribute names Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Element/Attribute names must be case sensitive (see #433) eclipse-lemminx/lemminx
1 participant
@angelozerr