Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preference to keep some whitespace on format. #350

Closed
NikolasKomonen opened this issue Apr 10, 2019 · 0 comments · Fixed by #364
Closed

Preference to keep some whitespace on format. #350

NikolasKomonen opened this issue Apr 10, 2019 · 0 comments · Fixed by #364
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone
v0.6.0

Comments

@NikolasKomonen
Copy link
Contributor

NikolasKomonen commented Apr 10, 2019 •
edited
Loading

In intellij when formatting:

<a> </a>




<b></b>

it will reduce to 2 newlines

<a> </a>


<b></b>

Maybe make a preference to set how many newlines to keep, as well as the ability to enable/disable entirely.

Single line whitespace will be kept as is.
@fbricon fbricon added enhancement New feature or request formatting This issue or enhancement is related to formatting support labels Apr 10, 2019
@NikolasKomonen NikolasKomonen added this to the v0.6.0 milestone Apr 26, 2019
@NikolasKomonen NikolasKomonen mentioned this issue Apr 26, 2019
Closed
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 30, 2019
@NikolasKomonen
Preserve whitespace on format
e0b19c6 
Fixes eclipse-lemminx#350

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Apr 30, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue May 1, 2019
@NikolasKomonen
Preserve whitespace on format
e4dfd93 
Fixes eclipse-lemminx#350

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue May 1, 2019
@NikolasKomonen
Preserve whitespace on format
776a23c 
Fixes eclipse-lemminx#350

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue May 6, 2019
@NikolasKomonen
Preserve whitespace on format
f073c55 
Fixes eclipse-lemminx#350

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue May 7, 2019
@NikolasKomonen
Preserve whitespace on format
7f9322e 
Fixes eclipse-lemminx#350

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue May 7, 2019
@NikolasKomonen @fbricon
Preserve whitespace on format
589c17c 
Fixes #350

Signed-off-by: Nikolas Komonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Preserve whitespace on format NikolasKomonen/lsp4xml
2 participants
@fbricon @NikolasKomonen