Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting document with unclosed closing tag moves said tag down #269

Closed
fbricon opened this issue Dec 19, 2018 · 5 comments
Closed

Formatting document with unclosed closing tag moves said tag down #269

fbricon opened this issue Dec 19, 2018 · 5 comments
Assignees
@NikolasKomonen
Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Milestone
v0.3.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Dec 19, 2018

formatting this:

<?xml version="1.0"?>
<note>
	<to>Fred</to
	<from>Jani</from>
		<heading>Reminder</heading>
			<body>Don't forget me this weekend</body>
</note>

yields:

<?xml version="1.0"?>
<note>
	<to>Fred<from>Jani</from>
		<heading>Reminder</heading>
		<body>Don't forget me this weekend</body>
	</to
</note>

The tag </to was moved down to enclose everything
@fbricon fbricon added bug Something isn't working formatting This issue or enhancement is related to formatting support labels Dec 19, 2018
@fbricon
Copy link
Contributor Author

fbricon commented Dec 19, 2018

this happens with master.

In the previous release, this would just remove the unclosed closing tag:

<?xml version="1.0"?>
<note>
	<to>Fred<from>Jani</from>
		<heading>Reminder</heading>
		<body>Don't forget me this weekend</body>
</note>

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 19, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
57a3bab 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 19, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
022e265 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Dec 19, 2018
Merged
@fbricon fbricon added this to the v0.0.3 milestone Dec 19, 2018
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 19, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
ddf633a 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue Dec 19, 2018
@NikolasKomonen @fbricon
Fixes unclosed element end tag in parser
8b97431 
Fixes #269

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon
Copy link
Contributor Author

fbricon commented Dec 19, 2018

I reverted the commit as it totally breaks dtd outline

@fbricon fbricon reopened this Dec 19, 2018
@NikolasKomonen
Copy link
Contributor

@fbricon Do you have an example of what breaks it?

@fbricon
Copy link
Contributor Author

fbricon commented Dec 20, 2018

No outline is returned at all

@NikolasKomonen
Copy link
Contributor

selection_012
@fbricon is yours not getting something like this?

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 20, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
926c33c 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 20, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
2bd1072 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Dec 20, 2018
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Dec 20, 2018
@NikolasKomonen
Fixes unclosed element end tag in parser
7e68d97 
Fixes eclipse-lemminx#269

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue Dec 20, 2018
@NikolasKomonen @fbricon
Fixes unclosed element end tag in parser
23f8355 
Fixes #269

Signed-off-by: Nikolas Komonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@fbricon @NikolasKomonen