Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoclose self-closing tags #239

Closed
fbricon opened this issue Nov 29, 2018 · 2 comments
Closed

Autoclose self-closing tags #239

fbricon opened this issue Nov 29, 2018 · 2 comments
Assignees
@NikolasKomonen
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request
Milestone
v0.5.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 29, 2018

As an improvement to tag autoclosing, if we type <foo /, the closing > should be added automatically (controlled by a new preference, autoCloseTags.selfClosingTags.enabled)
@fbricon fbricon added enhancement New feature or request completion This issue or enhancement is related to completion support labels Nov 29, 2018
@angelozerr
Copy link
Contributor

It should be cool if this option could manage too the same feature than WTP:

foo

@fbricon
Copy link
Contributor Author

fbricon commented Nov 30, 2018

Yes that's pretty cool. Need to make sure it only works if tag is empty

@NikolasKomonen NikolasKomonen added this to the v0.5.0 milestone Mar 11, 2019
@NikolasKomonen NikolasKomonen self-assigned this Mar 11, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 12, 2019
@NikolasKomonen
Stops autoClose of end tag if it already exists
f5a107c 
Fixes eclipse-lemminx#314, eclipse-lemminx#239

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Mar 12, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 12, 2019
@NikolasKomonen
Stops autoClose of end tag if it already exists
31a0a55 
Fixes eclipse-lemminx#314, eclipse-lemminx#239

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 13, 2019
@NikolasKomonen
Stops autoClose of end tag if it already exists
7d45bac 
Fixes eclipse-lemminx#314, eclipse-lemminx#239

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 13, 2019
@NikolasKomonen
Stops autoClose of end tag if it already exists
200968c 
Fixes eclipse-lemminx#314, eclipse-lemminx#239

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue Mar 13, 2019
@NikolasKomonen @fbricon
Stops autoClose of end tag if it already exists
d091cb7 
Fixes #314, #239

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon fbricon closed this as completed Mar 14, 2019
@fbricon fbricon mentioned this issue Jun 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
completion This issue or enhancement is related to completion support enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen