Multiple insert required attribute code actions shown when multiple attributes are missing

[fbricon]

Given an xml document:

<?xml version="1.0" encoding="UTF-8"?>
<invoice xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:noNamespaceSchemaLocation="invoice.xsd">
  <date>2017-11-30</date>
  <number>5235</number>
  <products>
    <product />
  </products>
  <payments>
    <payment amount="770.00" method="credit"/>
  </payments>
</invoice>

with an invoice.xsd:

<?xml version="1.0" encoding="UTF-8"?>
<xsd:schema elementFormDefault="qualified" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <xsd:element name="invoice" type="invoiceType"></xsd:element>
    
    <xsd:complexType name="invoiceType">
    	<xsd:sequence>
    		<xsd:element name="date" type="xsd:date"></xsd:element>
            <xsd:element name="number" type="xsd:int"></xsd:element>
            <xsd:element name="products" type="productsType"></xsd:element>
    		<xsd:element name="payments" type="paymentsType"></xsd:element>
    	</xsd:sequence>
    </xsd:complexType>

    <xsd:complexType name="productsType">
    	<xsd:choice minOccurs="1" maxOccurs="unbounded">
    		<xsd:element name="product" type="productType"></xsd:element>
    	</xsd:choice>
    </xsd:complexType>

    <xsd:complexType name="productType">
    	<xsd:attribute name="price" type="xsd:float" use="required"></xsd:attribute>
    	<xsd:attribute name="description" type="xsd:string" use="required"></xsd:attribute>
    </xsd:complexType>


    <xsd:complexType name="paymentsType">
    	<xsd:sequence minOccurs="1" maxOccurs="unbounded">
    		<xsd:element name="payment" type="paymentType"></xsd:element>
    	</xsd:sequence>
    </xsd:complexType>

    <xsd:complexType name="paymentType">
    	<xsd:attribute name="amount" type="xsd:float" use="required"></xsd:attribute>
    	<xsd:attribute name="method" type="paymentMethodType" use="required"></xsd:attribute>
    </xsd:complexType>

    <xsd:simpleType name="paymentMethodType">
    	<xsd:restriction base="xsd:string">
			<xsd:enumeration value="credit"></xsd:enumeration>
    		<xsd:enumeration value="debit"></xsd:enumeration>
    		<xsd:enumeration value="cash"></xsd:enumeration>
    		<xsd:enumeration value="aaaa"></xsd:enumeration>
    	</xsd:restriction>
    </xsd:simpleType>
</xsd:schema>

missing both attributes on the product tag generates duplicate code actions:

There are as many code actions as there are missing attributes. The server should not send duplicates

[angelozerr]

@fbricon I don't know how to fix this issues, because it seems that it's a LSP issues.

Indeed in your case, you have 2 diagnostics "cvc-complex-type.4" with the same "code" (but for each missing attributes):

{
    "jsonrpc": "2.0",
    "method": "textDocument/publishDiagnostics",
    "params": {
        "uri": "product.xml",


        "diagnostics": [{
                "range": {
                    "start": {
                        "line": 6,
                        "character": 5
                    },
                    "end": {
                        "line": 6,
                        "character": 12
                    }
                },
                "severity": 1,
                "code": "cvc-complex-type.4",
                "source": "xml",
                "message": "cvc-complex-type.4: Attribute \u0027price\u0027 must appear on element \u0027product\u0027."
            },
            {
                "range": {
                    "start": {
                        "line": 6,
                        "character": 5
                    },
                    "end": {
                        "line": 6,
                        "character": 12
                    }
                },
                "severity": 1,
                "code": "cvc-complex-type.4",
                "source": "xml",
                "message": "cvc-complex-type.4: Attribute \u0027description\u0027 must appear on element \u0027product\u0027."
            }
        ]
    }
}

LSP call for each diangnostics a code action (you have 2 requesest) and the lsp4xml server returns a response per request.

An uggly fix that I have in my mind, is to generate only one "cvc-complex-type.4-ALL" diagnostic and map code action in this cvc-complex-type.4-ALL (what do you think about this idea?)

[NikolasKomonen]

Im going to implement this by having a single code action insert all missing attributes