Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement itemDefaults for CompletionList #1561

Closed
JessicaJHee opened this issue Jul 28, 2023 · 1 comment · Fixed by #1567
Closed

Implement itemDefaults for CompletionList #1561

JessicaJHee opened this issue Jul 28, 2023 · 1 comment · Fixed by #1567
Assignees
@JessicaJHee
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request performance This issue or enhancement is related to performance concerns
Milestone
0.27.0

Comments

@JessicaJHee
Copy link
Contributor

In lemminx maven, there are completions that returns a lot of items in the result. To improve the performance, implement itemDefaults at the end of completion here:

https://github.com/eclipse/lemminx/blob/2b0fe29f52c111be3d5c1dccdf9d08340c63be31/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java#L290

The idea is to get the most common editRange between all completion items and set that as in itemDefaults.
@JessicaJHee JessicaJHee self-assigned this Jul 28, 2023
@JessicaJHee JessicaJHee moved this to 📋 Backlog in IDE Cloudaptors Jul 28, 2023
@JessicaJHee JessicaJHee added enhancement New feature or request completion This issue or enhancement is related to completion support performance This issue or enhancement is related to performance concerns labels Jul 28, 2023
@JessicaJHee JessicaJHee mentioned this issue Jul 31, 2023
Merged
@JessicaJHee JessicaJHee moved this from 📋 Backlog to 👀 In review in IDE Cloudaptors Jul 31, 2023
@angelozerr angelozerr added this to the 0.27.0 milestone Aug 2, 2023
@angelozerr
Copy link
Contributor

I wanted to test this feature inEclipse IDE but it seems it is not supported eclipse-lsp4e/lsp4e#741

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaJHee JessicaJHee

Labels
completion This issue or enhancement is related to completion support enhancement New feature or request performance This issue or enhancement is related to performance concerns
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Implement itemDefaults for completionList JessicaJHee/lemminx
2 participants
@angelozerr @JessicaJHee