Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary server doesn't show "element missing child" warning in broken RelaxNG #1460

Closed
datho7561 opened this issue Jan 24, 2023 · 2 comments · Fixed by #1461
Closed

Binary server doesn't show "element missing child" warning in broken RelaxNG #1460

datho7561 opened this issue Jan 24, 2023 · 2 comments · Fixed by #1461
Labels
Milestone

Comments

@datho7561
Copy link
Contributor

Given the following broken RelaxNG file:

<grammar xmlns="http://relaxng.org/ns/structure/1.0"
  datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
  <start>
    <ref name="root" />
  </start>
  <define name="root">
    <element name="root">
      <element name="child"></element>
    </element>
  </define>
</grammar>

There should be an error that "" requires a child, but when I run the binary server I don't see any errors in the document.

In the output, I get:

Message: Unexpected RNG Validator error
java.util.MissingResourceException: Can't find bundle for base name com.thaiopensource.relaxng.parse.sax.resources.Messages, locale en_CA

Based on this message, maybe this bug only happens when your locale is en_CA.

@angelozerr
Copy link
Contributor

We should add this resource in https://github.com/eclipse/lemminx/blob/main/org.eclipse.lemminx/src/main/resources/META-INF/native-image/resource-config.json no?

@datho7561 datho7561 added the bug Something isn't working label Jan 24, 2023
@datho7561
Copy link
Contributor Author

I'll make a quick PR to add it.

datho7561 added a commit to datho7561/lemminx that referenced this issue Jan 24, 2023
@datho7561 datho7561 added this to the 0.24.0 milestone Jan 24, 2023
@datho7561 datho7561 moved this to 👀 In review in IDE Cloudaptors Jan 24, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants