Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xml.format.enforceQuoteStyle setting with experimental formatter #1239

Closed
angelozerr opened this issue Jul 1, 2022 · 3 comments · Fixed by #1249 or redhat-developer/vscode-xml#737
Assignees
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone

Comments

@angelozerr
Copy link
Contributor

See https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatenforcequotestyle

@angelozerr angelozerr added the formatting This issue or enhancement is related to formatting support label Jul 1, 2022
@angelozerr
Copy link
Contributor Author

angelozerr commented Jul 1, 2022

@JessicaJHee are you interested in working on this issue?

@JessicaJHee
Copy link
Contributor

Yes looks interesting!

@angelozerr
Copy link
Contributor Author

angelozerr commented Jul 6, 2022

@JessicaJHee for the test I have copy/pasted the test from the old formatter in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/services/format/experimental/XMLFormatterQuoteStyleTest.java

All tests are disabled https://github.com/eclipse/lemminx/blob/a099dc2953cc6d87babec769d108b6c8274b26ae/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/services/format/experimental/XMLFormatterQuoteStyleTest.java#L31

The main idea is to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
3 participants