Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support folding for <!DOCTYPE #1213

Closed
angelozerr opened this issue Jun 1, 2022 · 0 comments · Fixed by #1219
Closed

Support folding for <!DOCTYPE #1213

angelozerr opened this issue Jun 1, 2022 · 0 comments · Fixed by #1219
Labels
enhancement New feature or request folding good first issue Good for newcomers
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jun 1, 2022

Given this xml file which defines DOCTYPE with a lof ENTITY:

<!DOCTYPE opt [
  <!ENTITY size "short">			
  <!ENTITY ResolutionX "1920"> 		
  <!ENTITY ResolutionY "1080">		
  <!ENTITY LevelMeterX "752">				
  <!ENTITY LevelMeterY "1036">			<!-- 44 -->				
  <!ENTITY PipDisplayX "845">				
  <!ENTITY PipDisplayY "1058">			<!-- 22 -->				
  <!ENTITY MainMenuButtonX "1191">
  <!ENTITY MainMenuButtonY "1011">		<!-- 69 -->
  <!ENTITY ToolbarButtonLeftX "707">
  <!ENTITY ToolbarButtonRightX "1194">
  <!ENTITY ToolbarButtonY1 "912">		<!--168 -->
  <!ENTITY ToolbarButtonY2 "947">		<!-- 133 -->
  <!ENTITY ToolbarButtonY3 "982">		<!-- 98 -->
  <!ENTITY QuickslotX "750">
  <!ENTITY QuickslotY "991">			<!-- 89 -->
  <!ENTITY QuickslotPageX "706">
  <!ENTITY QuickslotPageY "999">		<!-- 81 -->
  <!ENTITY LoadingScreenBarY "908">
  <!ENTITY LoadingScreenHintX "235">	
  <!ENTITY LoadingScreenHintY "752">
  <!ENTITY LoadingScreenWindowX "238">
  <!ENTITY LoadingScreenWindowY "240">
  <!ENTITY LoadingScreenWindowWidth "1024">
  <!ENTITY LoadingScreenWindowHeight "512">
  <!ENTITY LoadingScreenTextWidth "1000">
  <!ENTITY LoadingScreenAnimBox "100">
  <!ENTITY LoadingScreenAnimX "916">
  <!ENTITY LoadingScreenAnimY "-200">
]>
<opt>
  
</opt>

It should be nice to fold the DOCTYPE.

This sample comes from redhat-developer/vscode-xml#716

@angelozerr angelozerr added good first issue Good for newcomers folding labels Jun 1, 2022
@angelozerr angelozerr added this to the 0.21.0 milestone Jun 3, 2022
@datho7561 datho7561 added the enhancement New feature or request label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request folding good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants